Skip to content

Add the distribution tag to -print-target-info #81697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented May 22, 2025

Ideally this would also update the --version output to be overridden by SWIFT_TOOLCHAIN_VERSION, but unfortunately various tools rely on the current format (eg. swift-build).

@bnbarham bnbarham requested a review from shahmishal May 22, 2025 00:20
@bnbarham bnbarham requested a review from DougGregor as a code owner May 22, 2025 00:20
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham force-pushed the use-toolchain-version branch from 27f36ee to e90ea40 Compare May 22, 2025 23:23
@bnbarham bnbarham changed the title Allow the compiler tag to be overridden and used for --version Add the distribution tag to -print-target-info May 22, 2025
@bnbarham bnbarham requested a review from shahmishal May 22, 2025 23:23
@bnbarham
Copy link
Contributor Author

@xymus I've removed isCurrentCompilerTagged in preference for checking the serialization tag so that there's not two terminology's for "compiler tag". I'd also be happy naming the new one "distribution tag" or something similar if you'd prefer that.

Ideally this would also update the `--version` output to be overridden
by `SWIFT_TOOLCHAIN_VERSION`, but unfortunately various tools rely on
the current format (eg. swift-build).
@bnbarham bnbarham force-pushed the use-toolchain-version branch from e90ea40 to 561dafa Compare May 23, 2025 00:44
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@shahmishal I had to update this (see the PR description) :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants